linux-kernel - Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809300025.52904.rjw@sisk.pl>
Date:	Tue, 30 Sep 2008 00:25:52 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Karol Lewandowski <lmctlx@...il.com>
Cc:	Alexey Starikovskiy <astarikovskiy@...e.de>,
	Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: BUG: Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a makes special keys on my T21 unusable after resume

On Tuesday, 30 of September 2008, Karol Lewandowski wrote:
> Commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a causes my Thinkpad T21
> to no longer generate any hotkey events (e.g. suspend fn-f4, switch-output
> fn-f7, etc.) after resume.
> 
> It's regression from 2.6.25.  2.6.26 and 2.6.27-rc7 are broken,
> reverting that commit on 2.6.27-rc7 makes keys work again.
> 
> Thanks.
> 
> [Rafael added for regression tracking ;]
> 
> 
> commit 1b7fc5aae8867046f8d3d45808309d5b7f2e036a
> Author: Alexey Starikovskiy <astarikovskiy@...e.de>
> Date:   Fri Jun 6 11:49:33 2008 -0400
> 
>     ACPI: EC: Use msleep instead of udelay while waiting for event.
>     
>     http://bugzilla.kernel.org/show_bug.cgi?id=10724
>     
>     Signed-off-by: Alexey Starikovskiy <astarikovskiy@...e.de>
>     Signed-off-by: Len Brown <len.brown@...el.com>
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 0924992..5622aee 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -194,7 +194,7 @@ static int acpi_ec_wait(struct acpi_ec *ec, enum ec_event event, int force_poll)
>  		while (time_before(jiffies, delay)) {
>  			if (acpi_ec_check_status(ec, event))
>  				return 0;
> -			udelay(ACPI_EC_UDELAY);
> +			msleep(1);
>  		}
>  	}
>  	pr_err(PREFIX "acpi_ec_wait timeout, status = 0x%2.2x, event = %s\n",

Can you see if the patch at
http://bugzilla.kernel.org/attachment.cgi?id=18044&action=view
(against current -git) helps?

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/