linux-kernel - [PATCH] oom-killer kills more than needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2137b82d0809291609w3a888087j8aec348345a6f076@mail.gmail.com>
Date:	Mon, 29 Sep 2008 16:09:59 -0700
From:	"Chad Zanonie" <chad.zanonie@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] oom-killer kills more than needed

Signed-off-by: Chad Zanonie

This mod firstly replaces a !p->mm check with PF_KTHREAD to more
accurately identify
kthreads. Secondly, it adds a (p->state & TASK_DEAD) check to identify processes
that have released their mm entirely.  Not waiting for a process to finish
releasing its memory entirely can cause the OOM killer to kill another
application unnecessarily (while p->mm is null but memory isn't yet available).


diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 64e5b4b..f325a87 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -216,7 +216,7 @@ static struct task_struct
*select_bad_process(unsigned long *ppoints,
                 * skip kernel threads and tasks which have already released
                 * their mm.
                 */
-               if (!p->mm)
+               if (p->flags & PF_KTHREAD || p->state & TASK_DEAD)
                        continue;
                /* skip the init task */
                if (is_global_init(p))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/