linux-kernel - Re: [RFC PATCH 1/2] Shrink compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080929233842.GW25711@one.firstfloor.org>
Date:	Tue, 30 Sep 2008 01:38:42 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Andi Kleen <andi@...stfloor.org>, Pavel Machek <pavel@...e.cz>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/2] Shrink compat_ioctl.c

On Mon, Sep 29, 2008 at 06:27:10PM -0500, Matt Mackall wrote:
> I'm throwing this out untested as I don't have a mixed 64/32 system
> handy at the moment.

Makes sense (assuming it works, haven't tested)

> compat_ioctl: shrink structures
> 
> Initially, compat_ioctl.c has a ~18k table of translated ioctls.
> Each table entry is 24 bytes but we can shrink this to 16:
> 
> - use short table indexes rather than a pointer for .next values
> - use unsigned ints for cmd numbers (they're 32-bit ioctls, after all)
> 
> In addition, there's a 2k hash table that we can do away with simply
> by hashifying the main table in place at init time.

You mean by using a closed hash?

Acked-by: Andi Kleen <ak@...ux.intel.com>

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/