linux-kernel - Re: [PATCH 3/3] Add timeout feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CB0D828755EF47B78DA10F72C80BC436@nsl.ad.nec.co.jp>
Date:	Mon, 29 Sep 2008 20:11:41 +0900
From:	"Takashi Sato" <t-sato@...jp.nec.com>
To:	"Ric Wheeler" <rwheeler@...hat.com>,
	"Christoph Hellwig" <hch@...radead.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Oleg Nesterov" <oleg@...sign.ru>, <linux-fsdevel@...r.kernel.org>,
	<dm-devel@...hat.com>, <viro@...IV.linux.org.uk>,
	<linux-ext4@...r.kernel.org>, <xfs@....sgi.com>, <axboe@...nel.dk>,
	<mtk.manpages@...glemail.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] Add timeout feature

Hi Ric and Christoph,

Ric Wheeler wrote:
>>>> And as with all previous posting I still fundamentally disagree about
>>>> the need of this functionality.  We don't need a timeout for freezing.
>>>
>>> I agree with Christoph here, I think that the timeout is unneeded.
>>
>> I think that your concern is that the freezer cannot recognize the occurrence
>> of a timeout and it continues the backup process and the backup data is
>> corrupted finally.
>> If the freezer can recognize it by the unfreeze ioctl's errono, will your concern
>> be solved?
>> If so, I will implement it.
>>
>> Cheers, Takashi
>>
> I think that is certainly part a big part of my concern.
>
> Also note that the timeout seems to be quite low relative to say the standard timeout for a SCSI 
> device (30 seconds worst case).
>
> In general, I am quite supportive of the patch series and think that this is a great addition.

Thank you for your comments.
Christoph, do you have any comments about this solution?

If it's OK, I will change the freeze patch so that the unfreeze ioctl sets
ETIMEDOUT to errno when the timeout occurs.

Cheers, Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/