linux-kernel - Re: [PATCH 05/31] cpumask: Provide new cpumask API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080930091140.GB27452@elte.hu>
Date:	Tue, 30 Sep 2008 11:11:40 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Travis <travis@....com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jack Steiner <steiner@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/31] cpumask: Provide new cpumask API

* Mike Travis <travis@....com> wrote:

>     /* replaces cpumask_t dst = (cpumask_t)src */
>     void cpus_copy(cpumask_t dst, const cpumask_t src);

minor namespace nit i noticed while looking at actual usage of 
cpus_copy(): could you please rename it cpumask_set(dst, src)?

That streamlines it to have the same naming concept as atomic_set(), 
node_set(), zero_fd_set(), etc.

the patch-set looks quite nice otherwise already, the changes are 
straightforward and the end result already looks a lot more maintainable 
and not fragile at all.

In what way will Rusty's changes differ? Since you incorporate some of 
Rusty's changes already, could you please iterate towards a single 
patchset which we could then start testing?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/