linux-kernel - Re: [PATCH 0/2] x86: split out dumpstack code from traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Sep 2008 13:27:28 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexander van Heukelum <heukelum@...tmail.fm>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 0/2] x86: split out dumpstack code from traps_xx.c


* Alexander van Heukelum <heukelum@...tmail.fm> wrote:

> Hi Ingo,
> 
> I intend to keep looking for possibilities to bring traps_32.c and 
> traps_64.c closer to each-other. One trivial way (from my point of 
> view) is to split out code into separate files. These two patches 
> split out a large piece of code that has nothing to do with hardware 
> traps. Are you willing to take those two patches? Or are they to 
> intrusive?

they are not intrusive at all! The right way to do such things is to 
keep them in reasonably small files.

> Patches are against the current master branch of the tip tree. The 
> defconfigs compile fine and I ran some simple configs within qemu.

would be nice to bring dumpstack_32.c and dumpstack_64.c together as 
well. While some of the details like IST stack logic (which dont exist 
on 32-bit) are special, most of the glue, the iterators, the boot 
parameters, and even the output should be unified some more.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/