linux-kernel - Re: [PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace to the new type of print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0809300844270.1984@gandalf.stny.rr.com>
Date:	Tue, 30 Sep 2008 08:45:52 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frédéric Weisbecker <fweisbec@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>, Pekka Paalanen <pq@....fi>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 -tip 3/4] Tracing/ftrace: Adapt mmiotrace to the new
 type of print_line



On Tue, 30 Sep 2008, Fr?d?ric Weisbecker wrote:
> 
> Thanks Ingo.
> 
> I'm currently testing tip/master, since tracing/pipe is merged into.
> It seems there are some locking issues that I hadn't when I tested the patches.
> Perhaps it's because of the merge with the new ring buffer.
> 
> I just launched the sched_switch tracer and it worked well until 4
> seconds of execution. And after that it blocked.
> I tested too a marker message adding and it is never displayed. Worse:
> I can't break the pipe with Ctrl + C after that.
> 
> When I will have some time, I will try to debug all what I find.
> 

OK, I'll nuke the ring_buffer_lock :-/

The trace_pipe calls that and then calls print_trace_line which will 
eventually lock the buffer again. This is a bug on my part. I'll fix that 
today.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/