linux-kernel - Re: [PATCH] x86, Fix broken LDT access in VMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7848160809301549n5e8fb0fcr93ed10ba409b938e@mail.gmail.com>
Date:	Tue, 30 Sep 2008 18:49:58 -0400
From:	"Parag Warudkar" <parag.lkml@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Zachary Amsden" <zach@...are.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Ingo Molnar" <mingo@...hat.com>,
	"Glauber de Oliveira Costa" <gcosta@...hat.com>
Subject: Re: [PATCH] x86, Fix broken LDT access in VMI

On Tue, Sep 30, 2008 at 3:13 PM, Ingo Molnar <mingo@...e.hu> wrote:
>> -     vmi_ops.write_idt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);
>> +     vmi_ops.write_ldt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);

For a few seconds I thought it was diff going mad diff'ing exactly
similar lines.

This one could actually use some capitalization to reduce the
possibility of similar problems in future - rename to write_IDT_entry
and write_LDT_entry perhaps?

Parag
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/