linux-kernel - Re: [PATCH] Markers : marker_synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48E1853A.5090001@cn.fujitsu.com>
Date:	Tue, 30 Sep 2008 09:47:38 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
CC:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"Frank Ch. Eigler" <fche@...hat.com>
Subject: Re: [PATCH] Markers : marker_synchronize_unregister()

Mathieu Desnoyers wrote:
> Create marker_synchronize_unregister() which must be called before the end of
> exit() to make sure every probe callers have exited the non preemptible section
> and thus are not executing the probe code anymore.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
> CC: Ingo Molnar <mingo@...e.hu>
> CC: Rusty Russell <rusty@...tcorp.com.au>
> CC: akpm@...ux-foundation.org
> CC: "Frank Ch. Eigler" <fche@...hat.com>
> ---
>  include/linux/marker.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: linux-2.6-lttng/include/linux/marker.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/linux/marker.h	2008-07-31 09:12:52.000000000 -0400
> +++ linux-2.6-lttng/include/linux/marker.h	2008-07-31 09:19:31.000000000 -0400
> @@ -142,4 +142,11 @@ extern int marker_probe_unregister_priva
>  extern void *marker_get_private_data(const char *name, marker_probe_func *probe,
>  	int num);
>  
> +/*
> + * marker_synchronize_unregister must be called between the last marker probe
> + * unregistration and the end of module exit to make sure there is no caller
> + * executing a probe when it is freed.
> + */

marker_synchronize_unregister must be called _also_ between unregistration
and destruction the data that unregistration-ed probes need to make sure
there is no caller executing a probe when it's data is destroyed.



> +#define marker_synchronize_unregister() synchronize_sched()
> +
>  #endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/