linux-kernel - Re: [PATCH 12/13] hrtimer: create a "timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080930140930.ED5B.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Tue, 30 Sep 2008 14:16:09 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, dwmw2@...radead.org,
	drepper@...hat.com, mingo@...e.hu, tglx@...x.de
Subject: Re: [PATCH 12/13] hrtimer: create a "timer_slack" field in the task struct

Hi Arjan, 

Sorry for _really_ late responce.
I recently found this patch in linux-next.

In general, I like this patch.
However,

> +		case PR_SET_TIMERSLACK:
> +			if (arg2 <= 0)
> +				current->timer_slack_ns =
> +					current->default_timer_slack_ns;
> +			else
> +				current->timer_slack_ns = arg2;
> +			break;
>  		default:
>  			error = -EINVAL;
>  			break;

I wonder to why PR_SET_TIMERSLACK decreasing doesn't need root privilege.

example,
nice() systemcall is
  - nice increasing (pirority decreasing) doesn't need root privilege.
  - nice decreasing (priority incriasing) need root privilege.

So, I think time slack setting need similar one.
Otherwise, non-privilege user can increase power consumpsion easily by PR_SET_TIMERSLACK.

What do you think?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/