lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 01 Oct 2008 10:56:32 +0200 From: Takashi Iwai <tiwai@...e.de> To: Ingo Molnar <mingo@...e.hu> Cc: Steven Noonan <steven@...inklabs.net>, linux-kernel@...r.kernel.org Subject: Re: [PATCH -tip] pcm_native: label out defined but not used At Wed, 1 Oct 2008 10:32:24 +0200, Ingo Molnar wrote: > > > * Takashi Iwai <tiwai@...e.de> wrote: > > > At Wed, 1 Oct 2008 09:59:21 +0200, > > Ingo Molnar wrote: > > > > > > > > > (Cc:-ed Taskashi for this ALSA cleanup patch.) > > > > This label is used when the debug option is enabled. > > ah, indeed: > > snd_assert(substream != NULL, goto out); > > if then i'd suggest to clean it up like this: > > if (snd_assert(substream != NULL)) > goto out; > > this is how DEBUG_LOCKS_WARN_ON() is used in kernel/lockdep.c for > example. Putting code flow side-effects into debug macros looks a bit > weird. Yeah, already a similar change was done in the latest ALSA tree :) thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists