linux-kernel - Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081001105741.GA32062@elte.hu>
Date:	Wed, 1 Oct 2008 12:57:41 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Steven Noonan <steven@...inklabs.net>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be used
	uninitialized


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> On Wed, 1 Oct 2008 10:01:50 +0200
> Ingo Molnar <mingo@...e.hu> wrote:
> 
> > 
> > ( Alan Cc:-ed. Seems like gcc bogosity - so your solution of using
> >   uninitialized_var() is the correct way to annotate this. )
> 
> Sorry but uninitialized_var() is too ugly to be acceptable. Please use 
> a proper __foo style notation for consistency with the rest of the 
> kernel

it cannot be wrapped like that via __foo style notation (which can be 
used for section tricks), and uninitialized_var() is the accepted 
upstream facility for this, it got introduced 1.5 years ago, via commit 
94909914 ("Add unitialized_var() macro for suppressing gcc warnings").

> (Besides which last time I checked current gcc could figure that one 
> out)

that would indeed moot the patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/