linux-kernel - Re: [PATCH] mm: unify shmem and tiny-shmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5183.1222873201@redhat.com>
Date:	Wed, 01 Oct 2008 16:00:01 +0100
From:	David Howells <dhowells@...hat.com>
To:	Matt Mackall <mpm@...enic.com>
Cc:	dhowells@...hat.com, Hugh Dickins <hugh@...itas.com>,
	Nick Piggin <npiggin@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm: unify shmem and tiny-shmem

Matt Mackall <mpm@...enic.com> wrote:

> (This applies on top of Nick's second tiny-shmem patch, which hasn't
> made it to mainline yet(!). But as this deletes tiny-shmem.c, you can
> probably ignore the rejects.)
> 
> tiny-shmem shares most of its 130 lines of code with shmem and tends
> to break when particular bits of shmem get modified. Unifying saves
> code and makes keeping these two in sync much easier.
> 
> before:
>   14367	    392	     24	  14783	   39bf	mm/shmem.o
>     396      72       8     476	    1dc	mm/tiny-shmem.o
> 
> after:
>   14367	    392	     24	  14783	   39bf	mm/shmem.o
>     412	     72       8     492	    1ec	mm/shmem.o tiny
> 
> Signed-off-by: Matt Mackall <mpm@...enic.com>

Works with my test program:

	http://people.redhat.com/~dhowells/doshm.c

Compile and run:

	doshm sysv

warthog>size mm/tiny-shmem.o
   text    data     bss     dec     hex filename
    788      36       4     828     33c mm/tiny-shmem.o
warthog>size mm/shmem.o
   text    data     bss     dec     hex filename
    832      36       4     872     368 mm/shmem.o


Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/