[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081001174236.GA19954@elte.hu>
Date: Wed, 1 Oct 2008 19:42:36 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Pekka Paalanen <pq@....fi>, linux-kernel@...r.kernel.org,
Thomas Gleixner <tglx@...utronix.de>,
Peter Zijlstra <peterz@...radead.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Mathieu Desnoyers <compudj@...stal.dyndns.org>,
Frederic Weisbecker <fweisbec@...il.com>,
Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH] ftrace: type cast verifier
* Steven Rostedt <rostedt@...dmis.org> wrote:
> +#define FTRACE_CMP_TYPE(var, type) \
> + __builtin_types_compatible_p(typeof(var), type *)
ah, the -rt type trick ;-)
i'd suggest one more small detail:
> + struct trace_mmiotrace_map *field;
> + struct mmiotrace_map *m;
> + trace_assign_type(field, entry);
could you rename it to trace_type() - that way the initialization could
be written in a more compact way as:
> + struct trace_mmiotrace_map *field = trace_type(field, entry);
[ NOTE: there's namespace clash with a local symbol in ./trace_irqsoff.c
and a trace_type enum as well ]
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists