linux-kernel - Re: [PATCH v3 00/14] PCI: let the core manage slot names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081001210451.GA15531@ldl.fc.hp.com>
Date:	Wed, 1 Oct 2008 15:04:51 -0600
From:	Alex Chiang <achiang@...com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>
Cc:	jbarnes@...tuousgeek.org, kristen.c.accardi@...el.com,
	matthew@....cx, kaneshige.kenji@...fujitsu.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/14] PCI: let the core manage slot names

Hi Taku-san,

* Taku Izumi <izumi.taku@...fujitsu.com>:
>> This series applies against linux-next. I've tested this by loading
>> pci_slot and various hotplug drivers to ensure that the hotplug drivers
>> can successfully override the pci_slot names.
>
>  It seems that there are some bugs. Pciehp and shpchp modules can not
>  be loaded when the debug option is specified. Segmentation fault occurs
>  with stack dump.
>
>  pciehp_probe() or shpchp_probe()
>    -> init_slots()
>     -> get_power_status()
>      -> slot_name() : This is called when the debug option is specified.
>       -> hotplug_slot_name()
>        -> pci_slot_name(slot->pci_slot)
>                         ~~~~~~~~~~~~~~
>                        Not initialized yet.

Thank you for pointing this out. I've fixed this (and the other
drivers) by make sure that the slot names are initialized before
we attempt to use them.

Trying to fix rpaphp was too much work for very little gain, so I
deleted that patch from my patch series. But the changes to the
hotplug core still make sense, so it's ok to have just one
oddball left.

I'll wait until Kenji-san sends out his final review comments
before sending out v4.

Thanks.

/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/