linux-kernel - Re: [PATCH 9/12] memcg allocate all page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081001144150.3faa92ea.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 1 Oct 2008 14:41:50 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	balbir@...ux.vnet.ibm.com
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"nishimura@....nes.nec.co.jp" <nishimura@....nes.nec.co.jp>,
	"xemul@...nvz.org" <xemul@...nvz.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Hansen <haveblue@...ibm.com>, ryov@...inux.co.jp
Subject: Re: [PATCH 9/12] memcg allocate all page_cgroup at boot

On Wed, 01 Oct 2008 11:00:42 +0530
Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:

> KAMEZAWA Hiroyuki wrote:
> > On Wed, 01 Oct 2008 09:33:53 +0530
> > Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> > 
> >> Can we make this patch indepedent of the flags changes and push it in ASAP.
> >>
> > Need much work....Hmm..rewrite all again ? 
> > 
> 
> I don't think you'll need to do a major rewrite? Will you? 
yes. LOCK bit is on page_cgroup->flags bit.
Then, I'll check all places which modify page_cgroup->flags again and
take lock always.
This means I'll have to check dead-lock and preemption and irq-disable, again.

> My concern is that this patch does too much to be a single patch.
> Consider someone trying to do a
> git-bisect to identify a problem? It is hard to review as well and I think the
> patch that just removes struct page member can go in faster.
> 
Please apply atomic_flags first. this later.

> It will be easier to test/debug as well, we'll know if the problem is because of
> new page_cgroup being outside struct page rather then guessing if it was the
> atomic ops that caused the problem.
> 

atomic_ops patch just rewrite exisiting behavior.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/