linux-kernel - Re: [PATCH 1/2] ring_buffer: remove raw from local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081001060809.GA6646@elte.hu>
Date:	Wed, 1 Oct 2008 08:08:09 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Pekka Paalanen <pq@....fi>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Martin Bligh <mbligh@...gle.com>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 1/2] ring_buffer: remove raw from local_irq_save


> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > The raw_local_irq_save causes issues with lockdep. We don't need it
> > so replace them with local_irq_save.

the same warning still occurs with your latest fixes - see the log 
below. Config attached. You should be able to reproduce it, it happens 
on every bootup with this config.

	Ingo

[    0.159313] initcall relay_init+0x0/0x14 returned 0 after 0 msecs
[    0.159345] calling  tracer_alloc_buffers+0x0/0x1d9 @ 1
[    0.160001] ------------[ cut here ]------------
[    0.160001] WARNING: at kernel/lockdep.c:2880 check_flags+0x63/0x179()
[    0.160001] Modules linked in:
[    0.160001] Pid: 1, comm: swapper Not tainted 2.6.27-rc8-tip #37737
[    0.160001] Call Trace:
[    0.160001]  [<ffffffff80241faf>] warn_on_slowpath+0x5d/0x84
[    0.160001]  [<ffffffff80264776>] ? __lock_acquire+0xba4/0xbc5
[    0.160001]  [<ffffffff80261479>] ? __raw_spin_is_locked+0x17/0x1a
[    0.160001]  [<ffffffff802617d8>] ? graph_unlock+0x79/0x7e
[    0.160001]  [<ffffffff802632a2>] ? mark_lock+0x1c/0x361
[    0.160001]  [<ffffffff8026363d>] ? mark_held_locks+0x56/0x71
[    0.160001]  [<ffffffff8028c443>] ? time_hardirqs_off+0x12/0x26
[    0.160001]  [<ffffffff802622f4>] ? trace_hardirqs_off_caller+0x21/0xc2
[    0.160001]  [<ffffffff802615cf>] check_flags+0x63/0x179
[    0.160001]  [<ffffffff802654a4>] lock_acquire+0x51/0xc2
[    0.160001]  [<ffffffff80756775>] _spin_lock+0x36/0x65
[    0.160001]  [<ffffffff80287eec>] ? ring_buffer_reset_cpu+0x47/0x6b
[    0.160001]  [<ffffffff80287eec>] ring_buffer_reset_cpu+0x47/0x6b
[    0.160001]  [<ffffffff8028ac54>] tracing_reset+0xc/0xe
[    0.160001]  [<ffffffff8028d966>] boot_trace_init+0x2a/0x44
[    0.160001]  [<ffffffff80a9c0fd>] tracer_alloc_buffers+0x19b/0x1d9
[    0.160001]  [<ffffffff80a9bf62>] ? tracer_alloc_buffers+0x0/0x1d9
[    0.160001]  [<ffffffff8020a062>] do_one_initcall+0x62/0x165
[    0.160001]  [<ffffffff80a935a0>] ? setup_boot_APIC_clock+0x397/0x3af
[    0.160001]  [<ffffffff80226867>] ? get_apic_id+0x0/0x13
[    0.160001]  [<ffffffff80226867>] ? get_apic_id+0x0/0x13
[    0.160001]  [<ffffffff80a9bf62>] ? tracer_alloc_buffers+0x0/0x1d9
[    0.160001]  [<ffffffff80a898eb>] kernel_init+0x69/0x21f
[    0.160001]  [<ffffffff80212a59>] child_rip+0xa/0x11
[    0.160001]  [<ffffffff80211be3>] ? restore_args+0x0/0x30
[    0.160001]  [<ffffffff802265ac>] ? __ticket_spin_unlock+0x0/0x8
[    0.160001]  [<ffffffff80a89882>] ? kernel_init+0x0/0x21f
[    0.160001]  [<ffffffff80212a4f>] ? child_rip+0x0/0x11
[    0.160001] ---[ end trace a7919e7f17c0a725 ]---
[    0.160001] possible reason: unannotated irqs-off.
[    0.160001] irq event stamp: 3743
[    0.160001] hardirqs last  enabled at (3743): [<ffffffff802637c2>] trace_hardirqs_on+0xd/0xf
[    0.160001] hardirqs last disabled at (3742): [<ffffffff802623a2>] trace_hardirqs_off+0xd/0xf
[    0.160001] softirqs last  enabled at (798): [<ffffffff8024731b>] __do_softirq+0xe0/0xed
[    0.160001] softirqs last disabled at (791): [<ffffffff80212f4c>] call_softirq+0x1c/0x28
[    0.160011] initcall tracer_alloc_buffers+0x0/0x1d9 returned 0 after 3 msecs
[    0.160181] lockdep: fixing up alternatives.
[    0.160249] Booting processor 1 APIC 0x1 ip 0x6000
[    0.004000] Initializing CPU#1

View attachment "config" of type "text/plain" (62953 bytes)