linux-kernel - Re: [PATCH] drivers/serial/8250.c: 'i' may be used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081002090246.GD3550@elte.hu>
Date:	Thu, 2 Oct 2008 11:02:46 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Steven Noonan <steven@...inklabs.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/serial/8250.c: 'i' may be used uninitialized


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> On Wed,  1 Oct 2008 01:47:07 -0700
> Steven Noonan <steven@...inklabs.net> wrote:
> 
> > serial_unlink_irq_chain() does not initialize iterator 'i', and that is
> > correct logically because it is always initialized, either in the
> > hlist_for_each or in the conditional immediately after (which fires if
> > hlist_for_each comes up empty-handed). GCC does not realize this
> > connection and emits a false warning. Annotate it with uninitialized_var().
> > 
> > Signed-off-by: Steven Noonan <steven@...inklabs.net>
> 
> Ok definitive NAK. gcc 4.3.0 can work this out and doesn't produce a 
> warning. Thanks for sending the patch though (and to the gcc folks for 
> rendering it unnecessary)

thanks for sorting it out! A CONFIG_CC_DISABLE_WARNING_ANNOTATIONS=y 
might be useful as well, which could be used periodically (by gcc folks) 
to check which warnings are hidden by annotations?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/