linux-kernel - Re: [RFC patch 0/5] genirq: add infrastructure for threaded interrupt handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1222962525.2995.100.camel@laptop-eth>
Date:	Thu, 02 Oct 2008 08:48:45 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...l.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Arjan van de Veen <arjan@...radead.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jon Masters <jonathan@...masters.org>,
	Sven Dietrich <sdietrich@...e.de>
Subject: Re: [RFC patch 0/5] genirq: add infrastructure for threaded
	interrupt handlers

On Thu, 2008-10-02 at 11:02 -0400, Steven Rostedt wrote:
> On Wed, 1 Oct 2008, Daniel Walker wrote:
> > > 
> > > Converting an interrupt to threaded makes only sense when the handler
> > > code takes advantage of it by integrating tasklet/softirq
> > > functionality and simplifying the locking.
> > 
> > I'm not clear on your direction here.. I don't have a problem with a
> > mass driver audit, which I think is what your suggesting with this patch
> > set .. However, a mass audit like that would push a fully real time
> > system out for quite some time..
> 
> This has nothing to do with real time, although it helps.

Clearly threading irq handlers does have something to do with real time,
unless this patch isn't actually threading anything ..

> > 
> > I also don't see a clear connection between these changes and ultimately
> > removing spinlock level latency in the kernel. I realize you don't
> > address that in your comments, but this is part of the initiative to
> > remove spinlock level latency..
> 
> This is a completely different topic.

It's all connected to the removal of latency .. One part depending on
the other parts, so you can't disconnect this from the rest of it.

> > 
> > So with this set of changes and in terms of real time, I'm wonder your
> > going with this ?
> 
> This helps with latencies and locking. With the current scheme of hardirq, 
> softirq/tasklets, there are a lot of craziness with spin_locks and 
> spin_lock_irqs and mutexes.
> 
> By creating an interrupt thread, we can skip the softirq/tasklet 
> altogether, and this simplifies locking.

How does this simplify locking ?

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/