linux-kernel - Re: [PATCH 5/5] xen: nuke the ballon files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0810021357360.2919@gandalf.stny.rr.com>
Date:	Thu, 2 Oct 2008 13:59:40 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...source.com>,
	Chris Wright <chrisw@...s-sol.org>,
	Steven Rostedt <srostedt@...hat.com>
Subject: Re: [PATCH 5/5] xen: nuke the ballon files


On Thu, 2 Oct 2008, Jeremy Fitzhardinge wrote:

> Steven Rostedt wrote:
> > Investigating the unused static files in the balloon code, I discovered
> > that the balloon code is not used at all.
> > 
> > The header file is one big #if 0 and all the functions in the C file
> > is static. There is no caller like init_module to hook to any of
> > these functions. Basically, this code is one big patch of dead code
> > wasting space on my hard drive.
> > 
> > This patch removes the balloon code altogether since there are no
> > users.
> >   
> 
> Er, I think you should back away from that crack pipe.

No, coffee is my drug of choice. I did have a bit of overdose today ;-)

> 
> > -subsys_initcall(balloon_init);

Ouch! How did I miss that.

Anyway, there are still a bunch of functions in that code that are not 
referenced.  OK, nack this patch, but could you please supply one that 
cleans that code up.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/