linux-kernel - Re: [PATCH] rtc: fix kernel panic on second use of SIGIO nofitication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081003001238.7030c151@i1501.lan.towertech.it>
Date:	Fri, 3 Oct 2008 00:12:38 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Marcin Slusarz <marcin.slusarz@...il.com>,
	linux-kernel@...r.kernel.org, dbrownell@...rs.sourceforge.net,
	rtc-linux@...glegroups.com, stable@...nel.org
Subject: Re: [PATCH] rtc: fix kernel panic on second use of SIGIO
 nofitication

On Thu, 2 Oct 2008 14:49:41 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Sun, 14 Sep 2008 20:11:27 +0200
> Marcin Slusarz <marcin.slusarz@...il.com> wrote:
> 
> > When user space uses SIGIO notification and forgets to disable it before
> > closing file descriptor, rtc->async_queue contains stale pointer to struct
> > file. When user space enables again SIGIO notification in different process,
> > kernel dereferences this (poisoned) pointer and crashes.
> > 
> > So disable SIGIO notification on close.
> > 
> 
> David, Alessandro: can we please have a review-n-ack of this one for
> 2.6.27 and earlier?  
> 
> Thanks.
> 
> From: Marcin Slusarz <marcin.slusarz@...il.com>
> 
> When userspace uses SIGIO notification and forgets to disable it before
> closing file descriptor, rtc->async_queue contains stale pointer to struct
> file.  When user space enables again SIGIO notification in different
> process, kernel dereferences this (poisoned) pointer and crashes.
> 
> So disable SIGIO notification on close.

 [...]
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Alessandro Zummo <alessandro.zummo@...ertech.it>
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> Cc: <stable@...nel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

 
 Acked-by: Alessandro Zummo <a.zummo@...ertech.it>

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/