linux-kernel - Re: [regression] Latest git has WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810030746430.3230@nehalem.linux-foundation.org>
Date:	Fri, 3 Oct 2008 07:52:38 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christian Borntraeger <borntraeger@...ibm.com>
cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [regression] Latest git has WARN_ON storm with e1000e driver

On Fri, 3 Oct 2008, Christian Borntraeger wrote:
> 
> This is caused by holding a spinlock (__driver_attach) and checking for 
> preempt_count (e1000_acquire_swflag_ich8lan).

Which spinlock is it? It sure shouldn't be anything in the generic drievr 
layer: __driver_attach takes a lock, but it's a semaphore (dev->sem), not 
a spinlock. In fact, al lot of drivers will sleep or do allocations, so if 
the driver layer were to call the probe function with a spinlock held, 
things would be really broken.

The callchain has "spin_lock_irqsave" in it, but that's stale stack data. 

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/