linux-kernel - RE: [regression] Latest git has WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810030935390.3208@nehalem.linux-foundation.org>
Date:	Fri, 3 Oct 2008 09:36:28 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
cc:	Christian Borntraeger <borntraeger@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: RE: [regression] Latest git has WARN_ON storm with e1000e driver



On Fri, 3 Oct 2008, Brandeburg, Jesse wrote:
>
> Linus Torvalds wrote:
> > So this whole bug is actually because that debug test is just
> > _broken_. It shouldn't be WARN_ON(preempt_count()), it should be
> > 'might_sleep()', which does it right.
> > 
> > The right thing to check is "in_atomic() || irqs_disabled()".
> 
> okay, do you want me to post a patch?  I think Thomas is probably
> offline due to fridaynightitis.  Change the code to:?
> 
> WARN_ON(in_atomic() || irqs_disabled);

No, literally just "might_sleep()". It then does everything right, 
including taking into account that we allow certain behavior during bootup 
that we don't allow later.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/