linux-kernel - Re: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810032137390.4573@apollo>
Date:	Fri, 3 Oct 2008 21:38:44 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jiri Kosina <jkosina@...e.cz>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	arjan@...ux.intel.com, airlied@...il.com, davem@...emloft.net,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG

On Fri, 3 Oct 2008, Jiri Kosina wrote:
> On Fri, 3 Oct 2008, Linus Torvalds wrote:
> 
> > > The debugging message is racy anyway with respect to accessing 
> > > nvm_owner, right? It should be done after the mutex has been 
> > > succesfully acquired.
> > It's done that way on purpose - to see who _could_ be racing.
> 
> I know. I just wanted to point out that we probably don't want the patch 
> in 2.6.27 in this form, users wouldn't like to have warning in their logs 
> every time mutex is not acquired on a first attempt :)

Yeah, it should go before .27 final. It now just gathers data as
people actually care about warn_ons or they are even caught
automatically via kernel oops.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/