linux-kernel - Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0810032338140.26779@jikos.suse.cz>
Date:	Fri, 3 Oct 2008 23:45:07 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
cc:	David Miller <davem@...emloft.net>, jesse.brandeburg@...el.com,
	linux-kernel@...r.kernel.org, linux-netdev@...r.kernel.org,
	kkeil@...e.de, agospoda@...hat.com, arjan@...ux.intel.com,
	david.graham@...el.com, bruce.w.allan@...el.com,
	john.ronciak@...el.com, Thomas Gleixner <tglx@...utronix.de>,
	chris.jones@...onical.com, tim.gardner@...el.com,
	airlied@...il.com, Olaf Kirch <okir@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:

On Fri, 3 Oct 2008, Jesse Barnes wrote:

> Ok, thanks.  You'll have to check Linus' tree for sanity though, he just 
> merged a variant on my patch for 2.6.27.  See 
> b5ff7df3df9efab511244d5a299fce706c71af48 and yell if it broke something 
> for you.

Karsten has been testing kernel with these three patches from the series 
applied:

	e1000e: reset swflag after resetting hardware
	e1000e: fix lockdep issues
	e1000e: debug contention on NVM SWFLAG

This was done on a hardware which previously triggered the bug in just a 
few test iterations in quite a reliable way. Now, with these patches 
applied, the EEPROM corruption didn't happen after several tens of 
iterations.

Please note, that the patch that disables the writes to EEPROM on hardware 
level was *not* involved in this testing.

Therefore it currently seems that these three patches really address the 
race condition issue that was present in the e1000e driver.

It is still not clear why the bug started triggering all of a sudden for 
so many people though.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/