linux-kernel - Re: [PATCH -tip] Fastboot: fix initcalls disposition in bootgraph.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530810041328i282818cak8cd0ba36c450e3d6@mail.gmail.com>
Date:	Sat, 4 Oct 2008 22:28:49 +0200
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Arjan van de Ven" <arjan@...radead.org>
Cc:	mingo@...e.hu, rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	alan-jenkins@...fmail.co.uk
Subject: Re: [PATCH -tip] Fastboot: fix initcalls disposition in bootgraph.pl

2008/10/4 Arjan van de Ven <arjan@...radead.org>:
> On Sat, 04 Oct 2008 21:35:48 +0200
> Frederic Weisbecker <fweisbec@...il.com> wrote:
>
>> When bootgraph.pl parses a file, it gives one row
>> for each initcall's pid. But only few of them will
>> be displayed => the longest.
>> This patch corrects it by giving only a rows for pids
>> which have initcalls that will be displayed.
>> You can see the result in attachment, before and after the patch.
>>
>> Ingo, could you please revert the commit
>> b4bc656397071b18c99e85d9181f076e44de8a99 which was a false solution
>> to solve this problem. Thanks.
>
>
> I wonder about this.. there's only supposed to be 2....
> your graph is quite different.
>

I'm tracing all of the initcalls in my machine (even the modules).
If you look at both svg sources, you will see all of the 5 initcalls displayed.
But for the "before the patch" one, it depends on the software you are
using to visualize it.
With firefox you only see two of them. With the default gnome
visualization software (don't remember its name)
you can see all of them but in a very extensive image because a lot of
rows are unused.

With the "after the patch one", there is no issues....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/