linux-kernel - Re: [patch] fix printk format typo in boot ftracer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530810041358p1cc361b1te89894cedcd7e3b3@mail.gmail.com>
Date:	Sat, 4 Oct 2008 22:58:12 +0200
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Arjan van de Ven" <arjan@...radead.org>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [patch] fix printk format typo in boot ftracer.

2008/10/4 Arjan van de Ven <arjan@...radead.org>:
> When printing nanoseconds, the right printk format string is %09 not %06...
>
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index a7efe35..d0a5e50 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -62,14 +62,14 @@ static enum print_line_t initcall_print_line(struct trace_iterator *iter)
>        struct timespec rettime = ktime_to_timespec(it->rettime);
>
>        if (entry->type == TRACE_BOOT) {
> -               ret = trace_seq_printf(s, "[%5ld.%06ld] calling  %s @ %i\n",
> +               ret = trace_seq_printf(s, "[%5ld.%09ld] calling  %s @ %i\n",
>                                          calltime.tv_sec,
>                                          calltime.tv_nsec,
>                                          it->func, it->caller);
>                if (!ret)
>                        return TRACE_TYPE_PARTIAL_LINE;
>
> -               ret = trace_seq_printf(s, "[%5ld.%06ld] initcall %s "
> +               ret = trace_seq_printf(s, "[%5ld.%09ld] initcall %s "
>                                          "returned %d after %lld msecs\n",
>                                          rettime.tv_sec,
>                                          rettime.tv_nsec,

I picked these formats from the printk.c time formatting. But you're right,
09 would give us the whole nano precision.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/