linux-kernel - Re: [mmotm 02/Oct] fix buid error of autodetect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081004211237.CE4D.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Sat,  4 Oct 2008 21:18:14 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Ingo Molnar <mingo@...e.hu>, NeilBrown <neilb@...e.de>,
	Andre Noll <maan@...temlinux.org>
Cc:	kosaki.motohiro@...fujitsu.com,
	Arjan van de Ven <arjan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [mmotm 02/Oct] fix buid error of autodetect_raid()

Hi Ingo,

Thank you for very quick responce.

> > Index: b/init/do_mounts_md.c
> > ===================================================================
> > --- a/init/do_mounts_md.c
> > +++ b/init/do_mounts_md.c
> > @@ -1,5 +1,6 @@
> >  
> >  #include <linux/raid/md.h>
> > +#include <linux/delay.h>
> 
> hm, linux/raid/md.h already has:
> 
>   #include <linux/delay.h>
> 
> what config triggers this build failure, 

config attached.


> and does your version of 
> include/linux/raid/md.h have a linux/delay.h #include?

No.

git-md.patch of current mmotm has following hunk.
ok, CCing NeilBrown and Andre Noll.

> diff -puN include/linux/raid/md.h~git-md include/linux/raid/md.h
> --- a/include/linux/raid/md.h~git-md
> +++ a/include/linux/raid/md.h
> @@ -19,27 +19,7 @@
>  #define _MD_H
> 
>  #include <linux/blkdev.h>
> -#include <linux/major.h>
> -#include <linux/ioctl.h>
> -#include <linux/types.h>
> -#include <linux/bitops.h>
> -#include <linux/module.h>
> -#include <linux/hdreg.h>
> -#include <linux/proc_fs.h>
>  #include <linux/seq_file.h>
> -#include <linux/smp_lock.h>
> -#include <linux/delay.h>
> -#include <net/checksum.h>
> -#include <linux/random.h>
> -#include <linux/kernel_stat.h>
> -#include <asm/io.h>
> -#include <linux/completion.h>
> -#include <linux/mempool.h>
> -#include <linux/list.h>
> -#include <linux/reboot.h>
> -#include <linux/vmalloc.h>
> -#include <linux/blkpg.h>
> -#include <linux/bio.h>



Download attachment ".config" of type "application/octet-stream" (33479 bytes)