linux-kernel - Re: [PATCH] drivers/ide/ide-probe.c: uninitialized variable 'rc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200810051814.58293.bzolnier@gmail.com>
Date:	Sun, 5 Oct 2008 18:14:58 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	"Steven Noonan" <steven@...inklabs.net>
Cc:	"Elias Oltmanns" <eo@...ensachen.de>, linux-kernel@...r.kernel.org,
	mingo@...e.hu
Subject: Re: [PATCH] drivers/ide/ide-probe.c: uninitialized variable 'rc'

On Saturday 27 September 2008, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 11 September 2008, Steven Noonan wrote:
> > On Wed, Sep 10, 2008 at 3:40 PM, Elias Oltmanns <eo@...ensachen.de> wrote:
> > >
> > > What about changing the declaration to
> > >
> > >        int i, uninitialized_var(rc);
> > >
> > > then?
> > >
> > 
> > That's probably a -much- better idea. I'm an utter newbie to kernel
> > development, so I wasn't aware of that feature.
> 
> Did I miss the final patch version?
> 
> [ Could you please re-send and/or re-cast it? ]

Oh, well...

From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: [PATCH] ide: workaround for bogus gcc warning in ide_sysfs_register_port()

Reported-by: "Steven Noonan" <steven@...inklabs.net>
Suggested-by: "Elias Oltmanns" <eo@...ensachen.de>
Cc: mingo@...e.hu
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---
 drivers/ide/ide-probe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/ide/ide-probe.c
===================================================================
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -1492,7 +1492,7 @@ static struct device_attribute *ide_port
 
 static int ide_sysfs_register_port(ide_hwif_t *hwif)
 {
-	int i, rc;
+	int i, uninitialized_var(rc);
 
 	for (i = 0; ide_port_attrs[i]; i++) {
 		rc = device_create_file(hwif->portdev, ide_port_attrs[i]);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/