linux-kernel - [PATCH] Change comment in include linux/clk.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun,  5 Oct 2008 21:20:38 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Russell King <rmk+kernel@....linux.org.uk>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Alex Raimondi <raimondi@...omico.ch>,
	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Subject: [PATCH] Change comment in include linux/clk.h

From: Alex Raimondi <raimondi@...omico.ch>

clk_get and clk_put may not be used from within interrupt
context. Change comment to this function.

Signed-off-by: Alex Raimondi <raimondi@...omico.ch>
Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
---
I see several ARM implementation using mutexes for locking in these
functions. So I assume we never want to call them from interrupt
context, right?

 include/linux/clk.h |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/linux/clk.h b/include/linux/clk.h
index 5ca8c6f..7787773 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -35,6 +35,8 @@ struct clk;
  * clk_get may return different clock producers depending on @dev.)
  *
  * Drivers must assume that the clock source is not enabled.
+ *
+ * clk_get should not be called from within interrupt context.
  */
 struct clk *clk_get(struct device *dev, const char *id);
 
@@ -76,6 +78,8 @@ unsigned long clk_get_rate(struct clk *clk);
  * Note: drivers must ensure that all clk_enable calls made on this
  * clock source are balanced by clk_disable calls prior to calling
  * this function.
+ *
+ * clk_put should not be called from within interrupt context.
  */
 void clk_put(struct clk *clk);
 
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/