linux-kernel - Re: patch sata_nv-disable-hardreset-for-generic.patch added to 2.6.26-stable tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081005034800.GA7802@suse.de>
Date:	Sat, 4 Oct 2008 20:48:00 -0700
From:	Greg KH <gregkh@...e.de>
To:	Tejun Heo <tj@...nel.org>
Cc:	Stefan Lippers-Hollmann <s.L-H@....de>,
	linux-kernel@...r.kernel.org, jgarzik@...hat.com, pchen@...dia.com,
	stable@...nel.org
Subject: Re: patch sata_nv-disable-hardreset-for-generic.patch added to
	2.6.26-stable tree

On Sun, Oct 05, 2008 at 12:20:18PM +0900, Tejun Heo wrote:
> Greg KH wrote:
> >>> From 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 Mon Sep 17 00:00:00 2001
> >>> From: Tejun Heo <tj@...nel.org>
> >>> Date: Fri, 29 Aug 2008 16:13:12 +0200
> >>> Subject: sata_nv: disable hardreset for generic
> >>>
> >>> From: Tejun Heo <tj@...nel.org>
> >>>
> >>> commit 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 upstream
> >>>
> >>> of them being unifying probing, hotplug and EH reset paths uniform.
> >>> Previously, broken hardreset could go unnoticed as it wasn't used
> >>> during probing but when something goes wrong or after hotplug the
> >>> problem will surface and bite hard.
> >>>
> >>> OSDL bug 11195 reports that sata_nv generic flavor falls into this
> >>> category.  Hardreset itself succeeds but PHY stays offline after
> >>> hardreset.  I tried longer debounce timing but the result was the
> >>> same.
> >>>
> >>>   http://bugzilla.kernel.org/show_bug.cgi?id=11195
> >>>
> >>> So, it seems we'll have to drop hardreset from the generic flavor.
> >>>
> >>> Signed-off-by: Tejun Heo <tj@...nel.org>
> >>> Cc: Peer Chen <pchen@...dia.com>
> >>> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
> >>> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> >> On 2.6.26.5 + the pending stable queue applied, this patch results in lots 
> >> of noise in my syslog (full gzipped dmesg with and without this patch 
> >> attached):
> > 
> > This patch has been removed from the stable queue, so it shouldn't be an
> > issue anymore, right?
> 
> It's currently a mess.  Please take a look at the following message for
> the whole story.
> 
>   http://article.gmane.org/gmane.linux.ide/34942
> 
> It's interesting how they fixed hardreset of the chipset step-by-step. :-(

Ick, you are right, what a mess.

Do you want that patch in 2.6.26-stable now?  Or just don't worry about
it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/