linux-kernel - Re: [PATCH 1/3] x86: mtrr_cleanup: print out correct type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48E80D80.2090900@zytor.com>
Date:	Sat, 04 Oct 2008 17:42:40 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] x86: mtrr_cleanup: print out correct type

Yinghai Lu wrote:
> 
> Index: linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/cpu/mtrr/main.c
> +++ linux-2.6/arch/x86/kernel/cpu/mtrr/main.c
> @@ -1273,12 +1273,14 @@ static int __init mtrr_cleanup(unsigned
>  		size_base = to_size_factor(size_base, &size_factor),
>  		start_base = range_state[i].base_pfn << (PAGE_SHIFT - 10);
>  		start_base = to_size_factor(start_base, &start_factor),
> +		type = range_state[i].type;
>  
>  		printk(KERN_DEBUG "reg %d, base: %ld%cB, range: %ld%cB, type %s\n",
>  			i, start_base, start_factor,
>  			size_base, size_factor,
>  			(type == MTRR_TYPE_UNCACHABLE) ? "UC" :
> -			    ((type == MTRR_TYPE_WRBACK) ? "WB" : "Other")
> +			    ((type == MTRR_TYPE_WRPROT) ? "WPROT" :
> +			     ((type == MTRR_TYPE_WRBACK) ? "WB" : "Other"))
>  			);

If you're going to abbreviate, please use the standard abbreviations as 
documented in the manuals.  The abbreviation for write protect is WP.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/