lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20081006211830.4976f166.komurojun-mbn@nifty.com> Date: Mon, 6 Oct 2008 21:18:30 +0900 From: Komuro <komurojun-mbn@...ty.com> To: Alan Cox <alan@...rguk.ukuu.org.uk> Cc: linux-kernel@...r.kernel.org Subject: RE: [PATCH 03/19] pcmcia: Whine harder about use of EXCLUSIVE duplicate warning message in pcmcia_resource.c .... > /* Make sure the fact the request type was overridden is passed back */ > if (type == IRQF_SHARED && !(req->Attributes & IRQ_TYPE_DYNAMIC_SHARING)) { > req->Attributes |= IRQ_TYPE_DYNAMIC_SHARING; > printk(KERN_WARNING "pcmcia: request for exclusive IRQ could not be fulfilled.\n"); > printk(KERN_WARNING "pcmcia: the driver needs updating to supported shared IRQ lines\n"); > } >diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c >index 4884a18..8f1c3d4 100644 >--- a/drivers/pcmcia/pcmcia_resource.c >+++ b/drivers/pcmcia/pcmcia_resource.c >@@ -738,8 +738,9 @@ int pcmcia_request_irq(struct pcmcia_device *p_dev, irq_req_t *req) > type = 0; > if (s->functions > 1) /* All of this ought to be handled higher up */ > type = IRQF_SHARED; >- if (req->Attributes & IRQ_TYPE_DYNAMIC_SHARING) >+ else if (req->Attributes & IRQ_TYPE_DYNAMIC_SHARING) > type = IRQF_SHARED; >+ else printk(KERN_WARNING "pcmcia: Driver needs updating to support IRQ sharing.\n"); > > #ifdef CONFIG_PCMCIA_PROBE Best Regards Komuro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists