[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20081006095707.0c1b5a23@infradead.org>
Date: Mon, 6 Oct 2008 09:57:07 -0700
From: Arjan van de Ven <arjan@...radead.org>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Steven Rostedt <rostedt@...dmis.org>, mingo@...e.hu,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ftrace: Add a C-state tracer to help power
optimization
On Mon, 06 Oct 2008 18:52:39 +0200
Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> >
> >
> > #endif /* _LINUX_FTRACE_H */
>
> Why have the cstate_trace structure? If you just log start, stop you
> could compute the time delta from the trace time stamps, no?
there's 2 other fields I need than just the timestamp.
>
> If you decide to keep the structure, perhaps declare it empty for !
> CONFIG_CSTATE_TRACER so as to not bloat stack usage when its not
> configured.
ok good point
>
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists