linux-kernel - Re: [PATCH -mm -v3] Separate atomic_t declaration from asm/atomic.h into asm/atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081006050022.GA2186@elte.hu>
Date:	Mon, 6 Oct 2008 07:00:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH -mm -v3] Separate atomic_t declaration from
	asm/atomic.h into asm/atomic_def.h


* Huang Ying <ying.huang@...el.com> wrote:

> From: Huang Ying <ying.huang@...el.com>
> 
> asm/atomic.h contains both declaration and implementation of atomic_t.  So
> there are some implementation related files included in asm/atomic.h.  And
> atomic_t is a typedef.  Combination of above makes it impossible to use
> atomic_t in files included by atomic.h.  Such as atomic_t can not be used
> in linux/kernel.h on i386, because it is included by asm/atomic.h.
> 
> It is reasonable to separate declaration from implementation.  So a new
> file atomic_def.h is added for every architecture to accommodate the
> declaration of atomic_t.
> 
> Includes fixes from Andrew Moton.
> 
> Signed-off-by: Huang Ying <ying.huang@...el.com>
> ---
> 
>  include/asm-x86/atomic_32.h             |   10 +---------
>  include/asm-x86/atomic_64.h             |   10 +---------
>  include/asm-x86/atomic_def.h            |   13 +++++++++++++

nice cleanup!

One small request: could you please use the standard naming convention 
please and rename it to atomic_types.h?

That moves it in line with existing data type files: kvm_types.h, 
mm_types.h, posix_types.h, spinlock_types.h, amd_iommu_types.h, 
kmap_types.h, etc.

Easiest is to do it via:

 sed -i 's/atomic_def.h/atomic_types.h/g' patches/separate-atomic.patch

Reviewed-by: Ingo Molnar <mingo@...e.hu>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/