linux-kernel - Re: [PATCH 36/76] tty: Make get_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081006105659.GB9606@shell.devel.redhat.com>
Date:	Mon, 6 Oct 2008 06:56:59 -0400
From:	Alan Cox <alan@...hat.com>
To:	Louis Rilling <Louis.Rilling@...labs.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 36/76] tty: Make get_current_tty use a kref

On Mon, Oct 06, 2008 at 12:35:40PM +0200, Louis Rilling wrote:
> >  		tty = get_current_tty();
> >  		if (!tty || tty->driver->major != IBM_TTY3270_MAJOR) {
> > -			mutex_unlock(&tty_mutex);
> > +			tty_kref_put(tty);
> 
> Should'nt mutex_unlock() be kept?

Yes.. although it gets fixed later but I will fix that as it will keep the
code bisectable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/