linux-kernel - Re: [PATCH] markers: fix missing modpost entry in Module.markers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081007154401.5A59.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Tue,  7 Oct 2008 15:51:34 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <gregkh@...e.de>, stable@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Roland McGrath <roland@...hat.com>,
	Wenji Huang <wenji.huang@...cle.com>,
	Takashi Nishiie <t-nishiie@...css.fujitsu.com>,
	systemtap@...rceware.org
Subject: Re: [PATCH] markers: fix missing modpost entry in Module.markers

Hi Lai

Have you seen "Markers in (non-module) kernel code?" thread?
I think this patch and that patch treat the same issue.

In addition, I think mathieu's patch is better.
So, Could I hear your opinition for that?


> 
> commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
> marker points compiled in vmlinux are missing in Module.markers.
> 
> # cat Module.markers
> subsystem_event samples/markers/marker-example  integer %d string %s
> subsystem_eventb        samples/markers/marker-example
> 
> # stap -e 'probe kernel.mark("core_marker_format"){} '
> semantic error: no match while resolving probe point kernel.mark("core_marker_format")
> semantic error: no probes found
> Pass 2: analysis failed.  Try again with more '-v' (verbose) options.
> 
> This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
> Other parts have fixed duplicate modpost entry bug.
> 
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 418cd7d..3509142 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
>  			mod->skip = 1;
>  		}
>  
> -		if (!mod->skip)
> -			add_marker(mod, marker, fmt);
> +		add_marker(mod, marker, fmt);
>  	}
>  	return;
>  fail:
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/