linux-kernel - Re: [PATCH] pata_of_platform: fix no irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081007103723.0224671e@lxorguk.ukuu.org.uk>
Date:	Tue, 7 Oct 2008 10:37:23 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tejun Heo <tj@...nel.org>
Cc:	avorontsov@...mvista.com, Matt Sealey <matt@...esi-usa.com>,
	Jeff Garzik <jgarzik@...ox.com>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Li Yang <leoli@...escale.com>, Wang Jian <lark@...ux.net.cn>
Subject: Re: [PATCH] pata_of_platform: fix no irq handling

> > This was discussed years ago.
> > 
> > http://lkml.org/lkml/2005/11/22/159
> > http://lkml.org/lkml/2005/11/22/227
> > 
> 
> Would this break any existing platforms?  If so, can those be fixed
> together or does it become a much bigger problem that way?

Zero means no IRQ. Any platform with bits of code left over exposing IRQ
0 is already not supported by lots of driver code including libata.

As IRQs are unsigned using -1 is asking for trouble
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/