linux-kernel - Re: [PATCH] PM: use pm_op methods for device types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081006151127.GC1380@ucw.cz>
Date:	Mon, 6 Oct 2008 17:11:27 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Greg KH <greg@...ah.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Hannes Reinecke <hare@...e.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jirislaby@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] PM: use pm_op methods for device types


> > Okay, I was confused too.  Looking more closely, it's apparent that 
> > mainline is okay and the problem was introduced by Hannes Reinecke's 
> > 
> > driver-core-remove-suspend-resume-callbacks-for-device-type.patch
> > 
> > which states that the suspend/resume callbacks in struct device_type
> > are unused.  It may be true that the legacy suspend/resume methods are
> > unused, but the new pm_ops methods definitely are used.
> > 
> > Therefore part or all of Hannes patch should be reverted.  And the 
> > mainline is okay as it stands.
> 
> Ah, ick.
> 
> Hannes, care to respin this patch based on this information?

I guess Hannes patch shoud simply be dropped....

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/