linux-kernel - Re: [RFC PATCH] i_version: remount support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1223398312.3101.4.camel@localhost.localdomain>
Date:	Tue, 07 Oct 2008 12:51:52 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Mimi Zohar <zohar@...ibm.com>
Subject: Re: [RFC PATCH] i_version: remount support

On Tue, 2008-10-07 at 07:48 -0400, Christoph Hellwig wrote:
> On Tue, Oct 07, 2008 at 07:30:48AM -0400, Mimi Zohar wrote:
> > Add support for remounting a filesystem with the i_version option.
> > 
> > Signed-off-by: Mimi Zohar <zohar@...ibm.com>
> > ---
> > diff --git a/fs/super.c b/fs/super.c
> > index e931ae9..3758cbe 100644
> > --- a/fs/super.c
> > +++ b/fs/super.c
> > @@ -641,6 +641,8 @@ int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
> >  			return retval;
> >  	}
> >  	sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK);
> > +	if (flags & MS_I_VERSION)
> > +		sb->s_flags |= MS_I_VERSION;
> 
> The proper way would be to add it to MS_RMT_MASK.
> 

That works. Here's the replacement patch.

Thanks!

Mimi

Add support for remounting a filesystem with the i_version option.

Signed-off-by: Mimi Zohar <zohar@...ibm.com>

Index: security-testing-2.6/include/linux/fs.h
===================================================================
--- security-testing-2.6.orig/include/linux/fs.h
+++ security-testing-2.6/include/linux/fs.h
@@ -134,7 +134,7 @@ extern int dir_notify_enable;
 /*
  * Superblock flags that can be altered by MS_REMOUNT
  */
-#define MS_RMT_MASK	(MS_RDONLY|MS_SYNCHRONOUS|MS_MANDLOCK)
+#define MS_RMT_MASK	(MS_RDONLY|MS_SYNCHRONOUS|MS_MANDLOCK|MS_I_VERSION)
 
 /*
  * Old magic mount flag and mask


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/