linux-kernel - Re: [PATCH, RFC] percpu_counters: make fbc->count read atomic on 32 bit architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081007110407.f22b92e1.akpm@linux-foundation.org>
Date:	Tue, 7 Oct 2008 11:04:07 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	"Theodore Ts'o" <tytso@....edu>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH, RFC] percpu_counters: make fbc->count read atomic on 32
 bit architecture

On Tue, 07 Oct 2008 11:55:47 +0200 Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Mon, 2008-10-06 at 23:23 -0700, Andrew Morton wrote:
> > On Sun, 05 Oct 2008 21:28:10 -0400 "Theodore Ts'o" <tytso@....edu> wrote:
> > 
> > > The following patch has been sitting in the ext4 patch queue for about
> > > six weeks.  It was there it was a suspected cause for block allocation
> > > bug.  As I recall, it we found the true root cause since then, but this
> > > has stuck around since it's a potential problem.  Andrew has expressed
> > > concerns that this patch might have performance impacts.
> > 
> > Performace impacts I guess we'll just have to put up with.  iirc I was
> > thinking that this implementation should be pushed down to a kernel-wide
> > atomic64_t and then the percpu_counters would just use that type.
> 
> something like so?

We should think about and document the contexts in which these things
can be used.  Possibly add runtime checks too.  afaict they shouldn't be used in
hard IRQs, and that's pretty unusual for an atomic type.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/