linux-kernel - Re: [BUG] SLOB's krealloc() seems bust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1223403082.26330.78.camel@lappy.programming.kicks-ass.net>
Date:	Tue, 07 Oct 2008 20:11:22 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Matt Mackall <mpm@...enic.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Ingo Molnar <mingo@...e.hu>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...uxfoundation.org>,
	Pekka J Enberg <penberg@...helsinki.fi>
Subject: Re: [BUG] SLOB's krealloc() seems bust

On Tue, 2008-10-07 at 10:57 -0700, Linus Torvalds wrote:

> Peter - can you check with that
> 
> >  	if (slob_page(sp))
> > -		return ((slob_t *)block - 1)->units + SLOB_UNIT;
> > +		return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT;
> 
> thing using
> 
> -		return ((slob_t *)block - 1)->units + SLOB_UNIT;
> +		return ((slob_t *)block - 1)->units * SLOB_UNIT;
> 
> instead? 

went splat on the second run...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/