linux-kernel - Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081007211912.GF26373@wotan.suse.de>
Date:	Tue, 7 Oct 2008 14:19:12 -0700
From:	Mark Fasheh <mfasheh@...e.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, joel.becker@...cle.com,
	ocfs2-devel@....oracle.com, linux-fsdevel@...r.kernel.org,
	tao.ma@...cle.com
Subject: Re: [PATCH 11/39] ocfs2: Add extent tree operation for xattr value btrees

On Wed, Oct 01, 2008 at 11:12:05PM -0700, Andrew Morton wrote:
> > On Wed, 24 Sep 2008 15:00:52 -0700 Mark Fasheh <mfasheh@...e.com> wrote:
> > +	if (eb_bh)
> > +		brelse(eb_bh);
> 
> brelse(0) is legal.  Please do an fs-wide review for this.

Ok, I'll queue that up. I'll watch to make sure that new patches from here
on won't do this.


> It shouldn't affect code generation because brelse() is inlined.

Fair enough, thanks.
	--Mark


--
Mark Fasheh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/