linux-kernel - Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m18wt0qbwf.fsf@frodo.ebiederm.org>
Date:	Tue, 07 Oct 2008 15:27:12 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Greg KH <gregkh@...e.de>
Cc:	Mark Ryden <markryde@...il.com>,
	Benjamin Thery <benjamin.thery@...l.net>,
	David Shwatrz <dshwatrz@...il.com>, Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <htejun@...il.com>,
	Daniel Lezcano <dlezcano@...ibm.com>,
	linux-kernel@...r.kernel.org, Al Viro <viro@....linux.org.uk>,
	Linux Containers <containers@...ts.osdl.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support.

Greg KH <gregkh@...e.de> writes:

> On Tue, Oct 07, 2008 at 01:31:52PM -0700, Eric W. Biederman wrote:
>> Greg KH <gregkh@...e.de> writes:
>> 
>> > On Tue, Oct 07, 2008 at 06:39:04PM +0200, Mark Ryden wrote:
>> >> Hello,
>> >>   So I wonder: the sysfs tagged directory support patch is in GerKH
>> >> tree for more than a month.
>> >
>> > I dropped it from my tree 2 days ago, see the thread on lkml for why.
>> 
>> Greg why did you drop it? 
>
> Because Al said it was full of problems and for us not to accept it.

Yes. Al found problems.

Al reviewed sysfs with my patchset on top of it.

Al's review found problems in  sysfs with my patchset on top of it.

If you look at what Al found the majority of those problems exist in sysfs
without my patches.

Does the following sound like a workable path going forward?

- Not merge for 2.6.28 (we are to close to the merge window for everyone's comfort).

- Fix the small issues specific to tagged directory support that showed
  up in Al's review (patches sent).

- Keep the patches the entire time in a public tree that merges into
  linux-next so that people treat this code base seriously.

- Resolve the sysfs/vfs lock ordering problem mess that makes
  locking in sysfs excruciatingly difficult.

- Merge other patches to fix Als other issues with sysfs.

- Merge to 2.6.29 or wherever we are.


Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/