linux-kernel - Re: [Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081008132232.GG25392@lst.de>
Date:	Wed, 8 Oct 2008 15:22:32 +0200
From:	Christoph Hellwig <hch@....de>
To:	Mark Fasheh <mfasheh@...e.com>
Cc:	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, ocfs2-devel@....oracle.com,
	Tao Ma <tao.ma@...cle.com>
Subject: Re: [Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support

On Tue, Oct 07, 2008 at 03:08:11PM -0700, Mark Fasheh wrote:
> On Thu, Oct 02, 2008 at 10:16:44AM +0200, Christoph Hellwig wrote:
> > On Wed, Sep 24, 2008 at 03:00:54PM -0700, Mark Fasheh wrote:
> > >  	xattr.o			\
> > > +	xattr_user.o		\
> > > +	xattr_trusted.o
> > 
> > Please don't split this up, it's always been a really stupid idea in
> > extN.  The only difference between secure, trusted and user attrs is
> > that they go into a different namespace bit (and have different
> > permission checking, but that's handled in the VFS).  I have some
> > upcoming patches to store a fs private flag in struct xattr_handler
> > so that even those flags wrappers can go away, and each of the
> > namespaces will just be five lines of code for the xattr_handler
> > declaration.
> 
> Ok. The following patch (in ocfs2.git now) removes those two files, and puts
> the code for user and trusted xattrs at the bottom of xattr.c. Is that
> mainly what you were getting at here?

Yeah.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/