linux-kernel - Re: [PATCH] HPET: Remove spurious HPET busy warning message.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081008191608.GA27806@linux-os.sc.intel.com>
Date:	Wed, 8 Oct 2008 12:16:09 -0700
From:	Venki Pallipadi <venkatesh.pallipadi@...el.com>
To:	David John <davidjon@...ontk.org>
Cc:	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"clemens@...isch.de" <clemens@...isch.de>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	"vojtech@...e.cz" <vojtech@...e.cz>,
	"bob.picco@...com" <bob.picco@...com>
Subject: Re: [PATCH] HPET: Remove spurious HPET busy warning message.


Yes. This printk is not adding much value and tend to get people confused
making them think that it is some sort of error. It will be good to get rid
of them.

Ingo: Can you pick this patch up into tip?

Thanks,
Venki

Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>

On Mon, Oct 06, 2008 at 01:52:20AM -0700, David John wrote:
> On x86 systems with CONFIG_HPET_TIMER enabled
> and the HPET driver (drivers/char/hpet.c) compiled in,
> an incorrect busy message is printed when the driver
> initializes since the HPET has already been allocated
> by the core timer code. Remove the warning message.
> 
> Signed-off-by: David John <davidjon@...ontk.org>
> ---
>  drivers/char/hpet.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
> index b3f5dbc..454c13b 100644
> --- a/drivers/char/hpet.c
> +++ b/drivers/char/hpet.c
> @@ -874,8 +874,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
>                 hdp->hd_address = ioremap(addr.minimum, addr.address_length);
> 
>                 if (hpet_is_known(hdp)) {
> -                       printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> -                               __func__, hdp->hd_phys_address);
>                         iounmap(hdp->hd_address);
>                         return AE_ALREADY_EXISTS;
>                 }
> @@ -891,8 +889,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
>                                                 HPET_RANGE_SIZE);
> 
>                 if (hpet_is_known(hdp)) {
> -                       printk(KERN_DEBUG "%s: 0x%lx is busy\n",
> -                               __func__, hdp->hd_phys_address);
>                         iounmap(hdp->hd_address);
>                         return AE_ALREADY_EXISTS;
>                 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/