linux-kernel - Re: FRV/ARM unaligned access question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Oct 2008 13:22:50 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Russell King <rmk@....linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: FRV/ARM unaligned access question

On Wed, 2008-10-08 at 12:16 +0100, David Howells wrote:
> Harvey Harrison <harvey.harrison@...il.com> wrote:
> 
> Switching to the packed struct algorithms also reduces the kernel size very
> slightly.  Before:
> 
> 	warthog>size vmlinux
> 	   text    data     bss     dec     hex filename
> 	2207836   66588  150189 2424613  24ff25 vmlinux
> 
> After:
> 
> 	warthog>size vmlinux
> 	   text    data     bss     dec     hex filename
> 	2207804   66588  150189 2424581  24ff05 vmlinux

Probably smaller as now the le values aren't being byteswapped anymore,
only the native endianess can use the struct version.  Care to look at
the kernel size with the following instead?

From: Harvey Harrison <harvey.harrison@...il.com>
Subject: [PATCH] frv: switch unaligned access to the packed-struct implementation

Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
---
 include/asm-frv/unaligned.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-frv/unaligned.h b/include/asm-frv/unaligned.h
index 839a2fb..6c61c05 100644
--- a/include/asm-frv/unaligned.h
+++ b/include/asm-frv/unaligned.h
@@ -13,7 +13,7 @@
 #define _ASM_UNALIGNED_H
 
 #include <linux/unaligned/le_byteshift.h>
-#include <linux/unaligned/be_byteshift.h>
+#include <linux/unaligned/be_struct.h>
 #include <linux/unaligned/generic.h>
 
 #define get_unaligned	__get_unaligned_be
-- 
1.6.0.2.471.g47a76



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/