linux-kernel - Re: [PATCH 2/8 2.6.28] cxgb3 - Allocate multiqueues at init time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081008.174202.160320028.davem@davemloft.net>
Date:	Wed, 08 Oct 2008 17:42:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	divy@...lsio.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, swise@...ngridcomputing.com
Subject: Re: [PATCH 2/8 2.6.28] cxgb3 - Allocate multiqueues at init time

From: Divy Le Ray <divy@...lsio.com>
Date: Wed, 08 Oct 2008 17:34:02 -0700

> Allocate a queue set per core, up to the maximum of available qsets.
> Share the queue sets on multi port adapters.
> Rename MSI-X interrupt vectors ethX-N, N being the queue set number.
> 
> Signed-off-by: Divy Le Ray <divy@...lsio.com>

Applied, but...

This "num processors" logic and policy belongs in some generic place.
Perhaps "num_possible_cpus()" is more appropriate, who knows right?

Otherwise every stinking driver is going to implement this in
their own way and use their own policy, and from a user experience
perspective that totally sucks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/