linux-kernel - Re: [PATCH] markers: fix unchecked format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081009140505.GA2021@elte.hu>
Date:	Thu, 9 Oct 2008 16:05:05 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Lai Jiangshan <laijs@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] markers: fix unchecked format


* Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> wrote:

> * Lai Jiangshan (laijs@...fujitsu.com) wrote:
> > 
> > No.
> > 
> > 1)
> > In current code, when the second, third... probe is registered
> > with the same marker name, its format is not checked.
> > 
> > marker_probe_register("marker_name", "field1 %s", XXX);
> > marker_probe_register("marker_name", "field1 %d", XXX);
> > 
> > the second call, "field1 %d" is not check for ever.
> > and this probe may cause kernel core-dump.
> > 
> > because these two probes share the same marker_entry, and
> > we do not check the format when they are being shared.
> > 
> > if several probes share the same marker_entry we should
> > make sure all these probes's format are the same.
> > 
> 
> Yep, you are right. Thanks for the explanation.
> 
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

applied to tip/tracing/markers, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/