linux-kernel - Re: [RFC][PATCH 3/3] TXT: Intel(R) TXT and tboot kernel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081009175000.GC6912@sequoia.sous-sol.org>
Date:	Thu, 9 Oct 2008 10:50:00 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Pavel Machek <pavel@...e.cz>
Cc:	"Cihula, Joseph" <joseph.cihula@...el.com>,
	linux-kernel@...r.kernel.org, "Wang, Shane" <shane.wang@...el.com>,
	"Wei, Gang" <gang.wei@...el.com>,
	"Van De Ven, Arjan" <arjan.van.de.ven@...el.com>,
	"Mallick, Asit K" <asit.k.mallick@...el.com>,
	"Nakajima, Jun" <jun.nakajima@...el.com>,
	Chris Wright <chrisw@...hat.com>,
	Jan Beulich <jbeulich@...ell.com>, mingo@...e.hu, tytso@....edu
Subject: Re: [RFC][PATCH 3/3] TXT: Intel(R) TXT and tboot kernel support

* Pavel Machek (pavel@...e.cz) wrote:
> > +struct tboot_acpi_sleep_info {
> > +	u16 pm1a_cnt;
> > +	u16 pm1b_cnt;
> > +	u16 pm1a_evt;
> > +	u16 pm1b_evt;
> > +	u16 pm1a_cnt_val;
> > +	u16 pm1b_cnt_val;
> > +}  __attribute__ ((__packed__));
> > +
> > +struct tboot_shared {
> > +	/* version 0x01+ fields: */
> > +	struct tboot_uuid uuid; /* TBOOT_SHARED_UUID */
> > +	u32  version;      	/* Version number: 2 is current */
> > +	u32  log_addr;     	/* physical addr of tb_log_t log */
> > +	u32  shutdown_entry32;	/* entry point for tboot shutdown from
> > 32b */
> > +	u32  shutdown_entry64;	/* entry point for tboot shutdown from
> > 64b */
> 
> should these be function pointers?

I asked earlier, I didn't understand why it needs to be 2 fields, since
it's u32 in both cases and can't both be used at once.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/